fix: support negative array index for set/delete/map (#1077) - #1079
Open
arimu1 wants to merge 1 commit into
Open
fix: support negative array index for set/delete/map (#1077)#1079arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
Normalize negative array indices before creating the update PathRef so set, delete, and map resolve $[-n] the same way as read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1077
What
JsonPath.readalready resolves negative array indices (e.g.$[-1]→ last element).set,delete, andmapused the raw negative index when building the updatePathRef, so the JSON provider threw an uncaughtIndexOutOfBoundsException.Normalize the index (
length + indexwhen negative) before creating the updatePathRef, matching the read path.Why
Read and mutate should agree on
$[-n]. Callers should not get a raw JDK exception for a path that read already supports.Changes
PathToken.handleArrayIndex: computeeffectiveIndexfirst, thenPathRef.create(model, effectiveIndex)WriteTest: set / delete / map on$[-1]Test plan
./gradlew :json-path:test --tests com.jayway.jsonpath.WriteTest— 35/35 pass./gradlew :json-path:test— full module suite pass